linux-kernel - Re: [PATCH 2/6] staging: erofs: formatting fix to NULL comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180831094106.sxwsd5v2mmn3cux6@mwanda>
Date:   Fri, 31 Aug 2018 12:41:07 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Chao Yu <yuchao0@...wei.com>
Cc:     Gao Xiang <hsiangkao@....com>,
        Pavel Zemlyanoy <zemlyanoy@...ras.ru>,
        ldv-project@...uxtesting.org, devel@...verdev.osuosl.org,
        linux-erofs@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 2/6] staging: erofs: formatting fix to NULL comparison

On Fri, Aug 31, 2018 at 11:29:03AM +0800, Chao Yu wrote:
> 
> Hi Xiang,
> 
> I'm not against this change which follows checkpatch's rule, since I think this
> can help to unify coding style in different modules of Linux. Maybe cleanup in
> other filesystem is needed as well.
> 

That code is old, and those filesystems are not in staging so we're not
going to change them.

Let's just apply the patch and not spend any time thinking about it.
Part of the point of style guidelines is so that we don't have to
repeat all these discussions over and over...

Btw, I have a rename_rev.pl patch for reviewing these.  I've attached
it.  rename_rev.pl -r NULL.  I've seen some people screw up the
conversion so having an automated review is nice.

regards,
dan carpenter

View attachment "rename_rev.pl" of type "text/x-perl" (11926 bytes)