lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 31 Aug 2018 14:37:39 +0200 From: Geert Uytterhoeven <geert@...ux-m68k.org> To: Philipp Zabel <p.zabel@...gutronix.de> Cc: Lee Jones <lee.jones@...aro.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Sascha Hauer <kernel@...gutronix.de>, Marek Vasut <marek.vasut+renesas@...il.com>, Mark Brown <broonie@...nel.org>, Geert Uytterhoeven <geert+renesas@...der.be> Subject: Re: [PATCH] regulator: da9063: fix DT probing with constraints Hi Philipp, On Fri, Aug 31, 2018 at 2:34 PM Philipp Zabel <p.zabel@...gutronix.de> wrote: > Commit 1c892e38ce59 ("regulator: da9063: Handle less LDOs on DA9063L") > reordered the da9063_regulator_info[] array, but not the DA9063_ID_* > regulator ids and not the da9063_matches[] array, because ids are used > as indices in the array initializer. This mismatch between regulator id > and da9063_regulator_info[] array index causes the driver probe to fail > because constraints from DT are not applied to the correct regulator: > > da9063 0-0058: Device detected (chip-ID: 0x61, var-ID: 0x50) > DA9063_BMEM: Bringing 900000uV into 3300000-3300000uV > DA9063_LDO9: Bringing 3300000uV into 2500000-2500000uV > DA9063_LDO1: Bringing 900000uV into 3300000-3300000uV > DA9063_LDO1: failed to apply 3300000-3300000uV constraint(-22) My apologies for failing to notice that. > This patch reorders the DA9063_ID_* as apparently intended, and with > them the entries in the da90630_matches[] array. > > Fixes: 1c892e38ce59 ("regulator: da9063: Handle less LDOs on DA9063L") > Signed-off-by: Philipp Zabel <p.zabel@...gutronix.de> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Powered by blists - more mailing lists