lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 31 Aug 2018 14:56:15 +0100
From:   Al Viro <>
To:     Colin Ian King <>
Cc:, David Howells <>,
        "" <>
Subject: Re: fs: hfs: Possible issue with increment of extent

On Fri, Aug 31, 2018 at 02:39:11PM +0100, Colin Ian King wrote:
> Hi,
> Static analysis has picked up a potential issue with an out of bounds
> read in fs/hfs/extent.c; the following for-loop in  hfs_free_fork()
> increments i and also extent while also reading extent[i].count.  This
> looks incorrect to me, I think the increment of extent is not needed:
>         for (i = 0; i < 3; extent++, i++)
>                 blocks += be16_to_cpu(extent[i].count);
>         res = hfs_free_extents(sb, extent, blocks, blocks);
> I'm not familiar enough with the code to conclude that removing the
> increment of extent is necessary a correct fix just in case I'm missing
> something subtle here.

Goes back to commit d1081202f1d0 (in bk-to-git historical tree)
Author: Andrew Morton <>
Date:   Wed Feb 25 16:17:36 2004 -0800

    [PATCH] HFS rewrite
    From: Roman Zippel <>

and it's almost certainly a bug in there, judging by the code nearby...

Powered by blists - more mailing lists