linux-kernel - Re: [PATCH 01/23] infiniband: nes: add unlikely() to assert()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 31 Aug 2018 10:06:59 -0400
From:   Doug Ledford <dledford@...hat.com>
To:     Igor Stoppa <igor.stoppa@...il.com>, linux-kernel@...r.kernel.org
Cc:     Igor Stoppa <igor.stoppa@...wei.com>,
        Chien Tung <chien.tin.tung@...el.com>,
        Roland Dreier <rolandd@...co.com>,
        Faisal Latif <faisal.latif@...el.com>,
        Jason Gunthorpe <jgg@...pe.ca>
Subject: Re: [PATCH 01/23] infiniband: nes: add unlikely() to assert()

On Fri, 2018-08-31 at 01:34 +0300, Igor Stoppa wrote:
> Typically the assert is expected to not fail.
> 
> Signed-off-by: Igor Stoppa <igor.stoppa@...wei.com>
> Cc: Chien Tung <chien.tin.tung@...el.com>
> Cc: Roland Dreier <rolandd@...co.com>
> Cc: Faisal Latif <faisal.latif@...el.com>
> Cc: Doug Ledford <dledford@...hat.com>
> Cc: Jason Gunthorpe <jgg@...pe.ca>

Acked-by: Doug Ledford <dledford@...hat.com>

> ---
>  drivers/infiniband/hw/nes/nes.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/nes/nes.h b/drivers/infiniband/hw/nes/nes.h
> index bedaa02749fb..d2d0098f38e0 100644
> --- a/drivers/infiniband/hw/nes/nes.h
> +++ b/drivers/infiniband/hw/nes/nes.h
> @@ -151,7 +151,7 @@ do { \
>  
>  #define assert(expr) \
>  do { \
> -	if (!(expr)) { \
> +	if (unlikely(!(expr))) { \
>  		printk(KERN_ERR PFX "Assertion failed! %s, %s, %s, line %d\n", \
>  			   #expr, __FILE__, __func__, __LINE__); \
>  	} \

-- 
Doug Ledford <dledford@...hat.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)