linux-kernel - Re: [PATCH] kconfig: remove a spurious self-assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNAQDm+=55UvLKp3ox_a64WU=W55=2ftAQ7MmMxA5E-bXkw@mail.gmail.com>
Date:   Fri, 31 Aug 2018 23:45:58 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc:     Sam Ravnborg <sam@...nborg.org>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kconfig: remove a spurious self-assignment

2018-08-30 18:18 GMT+09:00 Lukas Bulwahn <lukas.bulwahn@...il.com>:
> The self assignment was probably introduced by an automated code
> refactoring in
> commit 694c49a7c01c ("kconfig: drop localization support").
>
> The issue was identified by a self-assign warning when running
> make menuconfig with clang.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
> ---

Applied to linux-kbuild/fixes. Thanks!


>  scripts/kconfig/mconf.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
> index 83b5836..143c05f 100644
> --- a/scripts/kconfig/mconf.c
> +++ b/scripts/kconfig/mconf.c
> @@ -490,7 +490,6 @@ static void build_conf(struct menu *menu)
>                         switch (prop->type) {
>                         case P_MENU:
>                                 child_count++;
> -                               prompt = prompt;
>                                 if (single_menu_mode) {
>                                         item_make("%s%*c%s",
>                                                   menu->data ? "-->" : "++>",
> --
> 2.7.4
>



-- 
Best Regards
Masahiro Yamada