lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sat, 1 Sep 2018 01:23:35 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kbuild <linux-kbuild@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "H. Nikolaus Schaller" <hns@...delico.com>,
        stable <stable@...r.kernel.org>,
        Lucas De Marchi <lucas.demarchi@...fusion.mobi>,
        Lucas De Marchi <lucas.de.marchi@...il.com>,
        Michal Marek <michal.lkml@...kovi.net>,
        Jessica Yu <jeyu@...nel.org>,
        Chih-Wei Huang <cwhuang@...ux.org.tw>
Subject: Re: [PATCH v4] modules_install: make missing $DEPMOD a Warning
 instead of an Error

2018-08-29 4:59 GMT+09:00 Randy Dunlap <rdunlap@...radead.org>:
> From: Randy Dunlap <rdunlap@...radead.org>
>
> When $DEPMOD is not found, only print a warning instead of exiting
> with an error message and error status:
>
> Warning: 'make modules_install' requires /sbin/depmod. Please install it.
> This is probably in the kmod package.
>
> Change the Error to a Warning because "not all build hosts for cross
> compiling Linux are Linux systems and are able to provide a working
> port of depmod, especially at the file patch /sbin/depmod."
>
> I.e., "make modules_install" may be used to copy/install the
> loadable modules files to a target directory on a build system and
> then transferred to an embedded device where /sbin/depmod is run
> instead of it being run on the build system.
>
> Fixes: 934193a654c1 ("kbuild: verify that $DEPMOD is installed")
>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: H. Nikolaus Schaller <hns@...delico.com>
> Cc: stable@...r.kernel.org
> Cc: Lucas De Marchi <lucas.demarchi@...fusion.mobi>
> Cc: Lucas De Marchi <lucas.de.marchi@...il.com>
> Cc: Michal Marek <michal.lkml@...kovi.net>
> Cc: Jessica Yu <jeyu@...nel.org>
> Cc: Chih-Wei Huang <cwhuang@...ux.org.tw>
> Cc: H. Nikolaus Schaller <hns@...delico.com>
> ---


Applied to linux-kbuild/fixes.  Thanks!


> v2: add missing "exit 0" and update the commit message (no Error).
> v3: add Fixes: and Cc: stable
> v4: add Reported-by: and more explanation for the patch.
>
>  scripts/depmod.sh |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- lnx-418.orig/scripts/depmod.sh
> +++ lnx-418/scripts/depmod.sh
> @@ -15,9 +15,9 @@ if ! test -r System.map ; then
>  fi
>
>  if [ -z $(command -v $DEPMOD) ]; then
> -       echo "'make modules_install' requires $DEPMOD. Please install it." >&2
> +       echo "Warning: 'make modules_install' requires $DEPMOD. Please install it." >&2
>         echo "This is probably in the kmod package." >&2
> -       exit 1
> +       exit 0
>  fi
>
>  # older versions of depmod require the version string to start with three
>
>



-- 
Best Regards
Masahiro Yamada

Powered by blists - more mailing lists