linux-kernel - Re: [PATCH v2] reset: hisilicon: fix potential NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <153573701576.93865.614018614668737096@swboyd.mtv.corp.google.com>
Date:   Fri, 31 Aug 2018 10:36:55 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Jiancheng Xue <xuejiancheng@...ilicon.com>,
        Michael Turquette <mturquette@...libre.com>
Cc:     linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Subject: Re: [PATCH v2] reset: hisilicon: fix potential NULL pointer dereference

Quoting Gustavo A. R. Silva (2018-07-25 17:47:19)
> There is a potential execution path in which function
> platform_get_resource() returns NULL. If this happens,
> we will end up having a NULL pointer dereference.
> 
> Fix this by replacing devm_ioremap with devm_ioremap_resource,
> which has the NULL check and the memory region request.
> 
> This code was detected with the help of Coccinelle.
> 
> Cc: stable@...r.kernel.org
> Fixes: 97b7129cd2af ("reset: hisilicon: change the definition of hisi_reset_init")
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---

Nobody has reviewed, so I guess applied to clk-next unless someone
complains.