linux-kernel - [PATCH] blkcg: fix call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1808311158220.2328@hadrien>
Date:   Fri, 31 Aug 2018 12:01:38 -0700 (PDT)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     dennisszhou@...il.com
cc:     Jens Axboe <axboe@...nel.dk>, Tejun Heo <tj@...nel.org>,
        Johannes Weiner <hannes@...xchg.org>,
        Josef Bacik <josef@...icpanda.com>, kernel-team@...com,
        linux-block@...r.kernel.org, cgroups@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        "Dennis Zhou (Facebook)" <dennisszhou@...il.com>
Subject: [PATCH] blkcg: fix call_kern.cocci warnings

From: kbuild test robot <fengguang.wu@...el.com>

block/blk-cgroup.c:243:57-67: ERROR: function blkg_create called on line 1260 inside lock on line 1259 but uses GFP_KERNEL
block/blk-cgroup.c:243:57-67: ERROR: function blkg_create called on line 922 inside lock on line 911 but uses GFP_KERNEL

Generated by: scripts/coccinelle/locks/call_kern.cocci

Fixes: 6ef69a3a0b4a ("blkcg: change blkg reference counting to use percpu_ref")
CC: Dennis Zhou (Facebook) <dennisszhou@...il.com>
Signed-off-by: kbuild test robot <fengguang.wu@...el.com>
Signed-off-by: Julia Lawall <julia.lawall@...6.fr>
---

url:    https://github.com/0day-ci/linux/commits/Dennis-Zhou/blkcg-ref-count-refactor-cleanup-blkcg-avg_lat/20180831-161742
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
:::::: branch date: 10 hours ago
:::::: commit date: 10 hours ago

The kbuild report doesn't include enough context to check this.  Please
check whether this is appropriate and whether another approach would be
better.


 blk-cgroup.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/block/blk-cgroup.c
+++ b/block/blk-cgroup.c
@@ -240,7 +240,7 @@ static struct blkcg_gq *blkg_create(stru
 		blkg_get(blkg->parent);
 	}

-	ret = percpu_ref_init(&blkg->refcnt, __blkg_release, 0, GFP_KERNEL);
+	ret = percpu_ref_init(&blkg->refcnt, __blkg_release, 0, GFP_ATOMIC);
 	if (ret)
 		goto err_cancel_ref;