lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 31 Aug 2018 21:17:48 +0200 From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com> To: Nick Desaulniers <ndesaulniers@...gle.com> Cc: Linus Torvalds <torvalds@...ux-foundation.org>, LKML <linux-kernel@...r.kernel.org>, Eli Friedman <efriedma@...eaurora.org>, Christopher Li <sparse@...isli.org>, Kees Cook <keescook@...omium.org>, Ingo Molnar <mingo@...nel.org>, Geert Uytterhoeven <geert@...ux-m68k.org>, Arnd Bergmann <arnd@...db.de>, Greg KH <gregkh@...uxfoundation.org>, Masahiro Yamada <yamada.masahiro@...ionext.com>, Joe Perches <joe@...ches.com>, Dominique Martinet <asmadeus@...ewreck.org> Subject: Re: [PATCH 2/7] Compiler Attributes: use the no-underscores syntax Hi Nick, On Fri, Aug 31, 2018 at 8:51 PM, Nick Desaulniers <ndesaulniers@...gle.com> wrote: > On Fri, Aug 31, 2018 at 10:05 AM Miguel Ojeda >> diff --git a/include/linux/compiler.h b/include/linux/compiler.h >> index 7c0157d50964..e0e55eb3f242 100644 >> --- a/include/linux/compiler.h >> +++ b/include/linux/compiler.h >> @@ -23,7 +23,7 @@ void ftrace_likely_update(struct ftrace_likely_data *f, int val, >> #define __branch_check__(x, expect, is_constant) ({ \ >> long ______r; \ >> static struct ftrace_likely_data \ >> - __attribute__((__aligned__(4))) \ >> + __attribute__((aligned(4))) \ > > Can this be __aligned(4)? As in make use of the newly feature detected > attributes? I was thinking of doing this in a full conversion over the full kernel tree in separate patch(es) after the 7th (maybe for v3?). In particular, aligned and section have a lot of them: * 349 ((aligned * 66 ((__aligned * 76 ((section * 48 ((__section As well as others like: * 218 ((unused * 14 ((__unused But indeed, good catches! These ones I can do it directly here since I am editing them anyway. > > With the above changes requested (or follow up patch added to the series): > Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com> > > Also, > Series looks great, trying to provide reviews one by one, just very > busy today (and Monday off). Thanks a lot! Cheers, Miguel
Powered by blists - more mailing lists