lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sat, 1 Sep 2018 00:16:01 +0200
From:   Miguel Ojeda <>
To:     Nick Desaulniers <>
Cc:     Joe Perches <>, Arnd Bergmann <>,
        Paul Burton <>,,
        Stafford Horne <>,
        Masahiro Yamada <>,
        Kees Cook <>,
        Ingo Molnar <>,
        Greg KH <>,
        Thomas Gleixner <>,
        Randy Dunlap <>,
        Borislav Petkov <>,,
        LKML <>,
        Andrey Ryabinin <>,,,
        Rasmus Villemoes <>,
        Paul Lawrence <>,
        Andrey Konovalov <>,
        Will Deacon <>,,, Greg Hackmann <>,
        Matthias Kaehlcke <>,
        Josh Poimboeuf <>,
        Wei Wang <>,,
        Nathan Chancellor <>,
        Andrew Morton <>
Subject: Re: [PATCH v2 1/2] compiler-clang.h: Add CLANG_VERSION and __diag macros

Hi Nick,

On Fri, Aug 31, 2018 at 11:50 PM, Nick Desaulniers
<> wrote:
> + Miguel and Joe
> This is the old patch I had sent for detecting Clang version.  If we
> wanted to set a minimal version, this plus the actual version should
> do it.  Probably could drop the diag stuff, as we changed clang to not
> warn in this case, so my solution using _Pragma is obsolete.

Nitpick: do we want to use the CLANG_VERSION notation? In some cases I
think it is easier to simply use directly the original values (like I
did in compiler_attributes.h for gcc).

Consider that we almost never need the patchlevel (and if we do, it is
better to *see* we are explicitly testing for it), and given the
versioning schemes that compilers nowadays use (i.e. only major
versions), I would bet not even the minor (except maybe for GCC in
compiler_attributes.h until we drop gcc < 5).


Powered by blists - more mailing lists