linux-kernel - Re: [PATCH 2/3] regmap: split up regmap_config.use_single

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201809011611.k0UahGKo%fengguang.wu@intel.com>
Date:   Sat, 1 Sep 2018 19:13:30 +0800
From:   kbuild test robot <lkp@...el.com>
To:     David Frey <dpfrey@...il.com>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org,
        broonie@...nel.org, David Frey <dpfrey@...il.com>
Subject: Re: [PATCH 2/3] regmap: split up regmap_config.use_single_rw

Hi David,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on asoc/for-next]
[also build test ERROR on v4.19-rc1 next-20180831]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/David-Frey/regmap-split-regmap_config-use_single_rw/20180901-141401
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: x86_64-randconfig-x013-201834 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

Note: the linux-review/David-Frey/regmap-split-regmap_config-use_single_rw/20180901-141401 HEAD ccc00a1af2b149f8dd70fe9bd1a047361070be43 builds fine.
      It only hurts bisectibility.

All error/warnings (new ones prefixed by >>):

>> drivers//hwmon/lm95245.c:544:3: error: 'const struct regmap_config' has no member named 'use_single_rw'; did you mean 'use_single_read'?
     .use_single_rw = true,
      ^~~~~~~~~~~~~
      use_single_read
>> drivers//hwmon/lm95245.c:544:19: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
     .use_single_rw = true,
                      ^~~~
   drivers//hwmon/lm95245.c:544:19: note: (near initialization for 'lm95245_regmap_config.reg_defaults_raw')
--
>> drivers//hwmon/tmp108.c:348:3: error: 'const struct regmap_config' has no member named 'use_single_rw'; did you mean 'use_single_read'?
     .use_single_rw = true,
      ^~~~~~~~~~~~~
      use_single_read
>> drivers//hwmon/tmp108.c:348:19: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
     .use_single_rw = true,
                      ^~~~
   drivers//hwmon/tmp108.c:348:19: note: (near initialization for 'tmp108_regmap_config.reg_defaults_raw')
--
>> drivers//iio/light/apds9960.c:209:3: error: 'const struct regmap_config' has no member named 'use_single_rw'; did you mean 'use_single_read'?
     .use_single_rw = 1,
      ^~~~~~~~~~~~~
      use_single_read
>> drivers//iio/light/apds9960.c:209:19: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
     .use_single_rw = 1,
                      ^
   drivers//iio/light/apds9960.c:209:19: note: (near initialization for 'apds9960_regmap_config.writeable_reg')

vim +544 drivers//hwmon/lm95245.c

fffd80cc Alexander Stein 2011-06-28  537  
c0a4b9ec Guenter Roeck   2016-07-05  538  static const struct regmap_config lm95245_regmap_config = {
c0a4b9ec Guenter Roeck   2016-07-05  539  	.reg_bits = 8,
c0a4b9ec Guenter Roeck   2016-07-05  540  	.val_bits = 8,
c0a4b9ec Guenter Roeck   2016-07-05  541  	.writeable_reg = lm95245_is_writeable_reg,
c0a4b9ec Guenter Roeck   2016-07-05  542  	.volatile_reg = lm95245_is_volatile_reg,
c0a4b9ec Guenter Roeck   2016-07-05  543  	.cache_type = REGCACHE_RBTREE,
c0a4b9ec Guenter Roeck   2016-07-05 @544  	.use_single_rw = true,
c0a4b9ec Guenter Roeck   2016-07-05  545  };
c0a4b9ec Guenter Roeck   2016-07-05  546  

:::::: The code at line 544 was first introduced by commit
:::::: c0a4b9ec1b43ebb9d5001e3bf86f58d4ca0ffe18 hwmon: (lm95245) Use new hwmon registration API

:::::: TO: Guenter Roeck <linux@...ck-us.net>
:::::: CC: Guenter Roeck <linux@...ck-us.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (33557 bytes)