linux-kernel - Re: [PATCH v2] rsi: remove set but not used variable 'header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 1 Sep 2018 14:54:31 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     Siva Rebbagondla <siva8118@...il.com>
CC:     Kalle Valo <kvalo@...eaurora.org>, <davem@...emloft.net>,
        <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
        Amit karwar <amit.karwar@...pinesignals.com>,
        <pavani.muthyala@...pinesignals.com>, <keescook@...omium.org>,
        Linux Wireless <linux-wireless@...r.kernel.org>
Subject: Re: [PATCH v2] rsi: remove set but not used variable 'header_size'

On 2018/9/1 11:41, Siva Rebbagondla wrote:
> On Fri, Aug 31, 2018 at 4:45 PM YueHaibing <yuehaibing@...wei.com> wrote:
>>
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/net/wireless/rsi/rsi_91x_hal.c: In function 'rsi_send_data_pkt':
>> drivers/net/wireless/rsi/rsi_91x_hal.c:288:5: warning:
>>  variable 'header_size' set but not used [-Wunused-but-set-variable]
>>
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>> ---
>> v2: remove unused 'tx_params'
>> ---
>>  drivers/net/wireless/rsi/rsi_91x_hal.c | 4 ----
>>  1 file changed, 4 deletions(-)
>>
>> diff --git a/drivers/net/wireless/rsi/rsi_91x_hal.c b/drivers/net/wireless/rsi/rsi_91x_hal.c
>> index 01edf96..182b066 100644
>> --- a/drivers/net/wireless/rsi/rsi_91x_hal.c
>> +++ b/drivers/net/wireless/rsi/rsi_91x_hal.c
>> @@ -282,10 +282,8 @@ int rsi_send_data_pkt(struct rsi_common *common, struct sk_buff *skb)
>>         struct rsi_hw *adapter = common->priv;
>>         struct ieee80211_vif *vif;
>>         struct ieee80211_tx_info *info;
>> -       struct skb_info *tx_params;
>>         struct ieee80211_bss_conf *bss;
>>         int status = -EINVAL;
>> -       u8 header_size;
>>
>>         if (!skb)
>>                 return 0;
>> @@ -297,8 +295,6 @@ int rsi_send_data_pkt(struct rsi_common *common, struct sk_buff *skb)
>>                 goto err;
>>         vif = info->control.vif;
>>         bss = &vif->bss_conf;
>> -       tx_params = (struct skb_info *)info->driver_data;
>> -       header_size = tx_params->internal_hdr_size;
> Yes, These redundant variables shall be removed.
>>
>>         if (((vif->type == NL80211_IFTYPE_STATION) ||
>>              (vif->type == NL80211_IFTYPE_P2P_CLIENT)) &&
>> --
>> 2.7.0
>>
>>
> Also, Patch title also can be changed to "[v2] rsi: remove unused variables"

Ok, will fix in v3.

Thank you.

> 
> Thanks,
> Siva Rebbagondla
> 
> .
>