lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 2 Sep 2018 20:58:46 +0100 From: Jonathan Cameron <jic23@...nel.org> To: Maxime Ripard <maxime.ripard@...tlin.com> Cc: Philipp Rossak <embed3d@...il.com>, lee.jones@...aro.org, robh+dt@...nel.org, mark.rutland@....com, wens@...e.org, linux@...linux.org.uk, knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net, eugen.hristev@...rochip.com, rdunlap@...radead.org, vilhelm.gray@...il.com, clabbe.montjoie@...il.com, quentin.schulz@...tlin.com, geert+renesas@...der.be, lukas@...ner.de, icenowy@...c.io, arnd@...db.de, broonie@...nel.org, arnaud.pouliquen@...com, linux-iio@...r.kernel.org, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, linux-sunxi@...glegroups.com Subject: Re: [PATCH v3 01/30] mfd: Makefile: Remove build option for MFD:sun4i-gpadc On Fri, 31 Aug 2018 10:25:45 +0200 Maxime Ripard <maxime.ripard@...tlin.com> wrote: > Hi Philipp, > > First, thanks for doing that rework. It was needed, and it's very much > appreciated :) > > As you can imagine though, I have a bunch of comments. > > On Thu, Aug 30, 2018 at 05:44:49PM +0200, Philipp Rossak wrote: > > Since we are merging the mfd driver into the sun4i-gpadc driver we need > > to remove the build options for the sun4i-gpadc driver. > > > > Signed-off-by: Philipp Rossak <embed3d@...il.com> > > --- > > drivers/mfd/Makefile | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > > index e9fd20dba18d..c680994db988 100644 > > --- a/drivers/mfd/Makefile > > +++ b/drivers/mfd/Makefile > > @@ -220,7 +220,6 @@ obj-$(CONFIG_INTEL_SOC_PMIC_CHTDC_TI) += intel_soc_pmic_chtdc_ti.o > > obj-$(CONFIG_MFD_MT6397) += mt6397-core.o > > > > obj-$(CONFIG_MFD_ALTERA_A10SR) += altera-a10sr.o > > -obj-$(CONFIG_MFD_SUN4I_GPADC) += sun4i-gpadc.o > > One of the things we should strive for is bisectability, which means > being able to have a working driver at every point in time while > introducing the features. > > In this particular case, this isn't really a problem since you're > removing part of code that were never really enabled, but you should > at least document why in your commit log. > Agreed. I for one don't know / can't remember why this would make sense! Jonathan > Thanks! > Maxime >
Powered by blists - more mailing lists