linux-kernel - Re: [PATCH] infiniband: core: mad: Fix a sleep-in-atomic-context bug in ib_mad_recv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 2 Sep 2018 14:32:29 -0600
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Jia-Ju Bai <baijiaju1990@...il.com>
Cc:     dledford@...hat.com, leon@...nel.org, ira.weiny@...el.com,
        pravin.shedge4linux@...il.com, hal@...lanox.com,
        parav@...lanox.com, haakon.bugge@...cle.com,
        bart.vanassche@...disk.com, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] infiniband: core: mad: Fix a sleep-in-atomic-context bug
 in ib_mad_recv_done()

On Sat, Sep 01, 2018 at 08:06:59PM +0800, Jia-Ju Bai wrote:
> The driver may sleep with holding a spinlock.
> 
> The function call paths (from bottom to top) in Linux-4.16 are:
> 
> [FUNC] alloc_mad_private(GFP_KERNEL)
> drivers/infiniband/core/mad.c, 2264: 
> 	alloc_mad_private in ib_mad_recv_done
> drivers/infiniband/core/cq.c, 45: 
> 	[FUNC_PTR]ib_mad_recv_done in __ib_process_cq
> drivers/infiniband/core/cq.c, 77: 
> 	__ib_process_cq in ib_process_cq_direct
> drivers/infiniband/ulp/srp/ib_srp.c, 2010: 
> 	ib_process_cq_direct in __srp_get_tx_iu
> drivers/infiniband/ulp/srp/ib_srp.c, 2353: 
> 	__srp_get_tx_iu in srp_queuecommand
> drivers/infiniband/ulp/srp/ib_srp.c, 2352: 
> 	_raw_spin_lock_irqsave in srp_queuecommand
> 
> [FUNC] alloc_mad_private(GFP_KERNEL)
> drivers/infiniband/core/mad.c, 2264: 
> 	alloc_mad_private in ib_mad_recv_done
> drivers/infiniband/core/cq.c, 45: 
> 	[FUNC_PTR]ib_mad_recv_done in __ib_process_cq
> drivers/infiniband/core/cq.c, 77: 
> 	__ib_process_cq in ib_process_cq_direct

This trace doesn't seem right, the CQ used by SRP will never have
ib_mad_recv_done as a function pointer.

Jason