linux-kernel - Re: [PATCH 2/2] x86/mm/KASLR: Adjust the vmemmap size according to paging mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180902205242.kcpt6wsatacahswp@kshutemo-mobl1>
Date:   Sun, 2 Sep 2018 23:52:42 +0300
From:   "Kirill A. Shutemov" <kirill@...temov.name>
To:     Baoquan He <bhe@...hat.com>
Cc:     tglx@...utronix.de, mingo@...nel.org, hpa@...or.com,
        thgarnie@...gle.com, kirill.shutemov@...ux.intel.com,
        x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] x86/mm/KASLR: Adjust the vmemmap size according to
 paging mode

On Thu, Aug 30, 2018 at 11:25:12PM +0800, Baoquan He wrote:
> Hi Kirill,
> 
> I made a new version according to your suggestion, just a little
> different, I didn't make 1TB as default, just calculate with the actual
> size, then align up to 1TB boundary.  Just found kcore is printing more
> entries than before, I thought it's caused by my code, later got it was
> touchde by other people.
> 
> Any comment about this? I can change accordingly.

Looks good to me.

But there's corner case when struct page is unreasonably large and
vmemmap_size will be way to large. We probably have to report an error if
we cannot fit vmemmap properly into virtual memory layout.

-- 
 Kirill A. Shutemov