linux-kernel - Re: [PATCH v5] usb: core: phy: clean up return value check about devm_of_phy_get_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFBinCB8J1TP_xsg8cprHBzQrNwUVg7TxbRBw3GamyWUe8yH7g@mail.gmail.com>
Date:   Mon, 3 Sep 2018 20:09:31 +0200
From:   Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To:     chunfeng.yun@...iatek.com
Cc:     gregkh@...uxfoundation.org, felipe.balbi@...ux.intel.com,
        matthias.bgg@...il.com, johan@...nel.org,
        linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v5] usb: core: phy: clean up return value check about devm_of_phy_get_by_index()

On Fri, Aug 31, 2018 at 12:02 PM Chunfeng Yun <chunfeng.yun@...iatek.com> wrote:
>
> Use IS_ERR() instead of IS_ERR_OR_NULL() because devm_of_phy_get_by_index()
> never return NULL value;
> But still need ignore the error of -ENODEV, for more information, please
> refer to:
> [0] https://lkml.org/lkml/2018/4/19/88
> [1] https://patchwork.kernel.org/patch/10160181/
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@...iatek.com>
> Reviewed-by: Johan Hovold <johan@...nel.org>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>

thanks to both of you for fixing my code!


Regards
Martin