linux-kernel - Re: [PATCH v6 6/9] soc: qcom: Remove depends on OF from QCOM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180903192407.GC3456@tuxbook-pro>
Date:   Mon, 3 Sep 2018 12:24:07 -0700
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Niklas Cassel <niklas.cassel@...aro.org>
Cc:     Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 6/9] soc: qcom: Remove depends on OF from QCOM_RPMH

On Wed 29 Aug 00:57 PDT 2018, Niklas Cassel wrote:

> QCOM_RPHM already selects ARM64, which always selects OF.

Nit. "already depends on ARM64"

> 
> Additionally, the rpmh driver only uses linux/of.h, which has dummy
> definitions for all functions, in order for code to to be able to
> build without CONFIG_OF set.
> 
> Remove the superfluous depends on OF.
> 
> Signed-off-by: Niklas Cassel <niklas.cassel@...aro.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Regards,
Bjorn

> ---
>  drivers/soc/qcom/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index ac657164a136..cf4ece232897 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -94,7 +94,7 @@ config QCOM_RMTFS_MEM
>  
>  config QCOM_RPMH
>  	bool "Qualcomm RPM-Hardened (RPMH) Communication"
> -	depends on ARCH_QCOM && ARM64 && OF || COMPILE_TEST
> +	depends on ARCH_QCOM && ARM64 || COMPILE_TEST
>  	help
>  	  Support for communication with the hardened-RPM blocks in
>  	  Qualcomm Technologies Inc (QTI) SoCs. RPMH communication uses an
> -- 
> 2.17.1
>