linux-kernel - Re: [PATCH v6 9/9] soc: qcom: Allow COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180903192531.GE3456@tuxbook-pro>
Date:   Mon, 3 Sep 2018 12:25:31 -0700
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Niklas Cassel <niklas.cassel@...aro.org>
Cc:     Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 9/9] soc: qcom: Allow COMPILE_TEST of qcom SoC Kconfigs

On Wed 29 Aug 00:57 PDT 2018, Niklas Cassel wrote:

> Since commit cab673583d96 ("soc: Unconditionally include qcom Makefile"),
> we unconditionally include the soc/qcom/Makefile.
> 
> This opens up the possibility to compile test the code even when building
> for other architectures.
> 
> Allow COMPILE_TEST for all qcom SoC Kconfigs, except for two Kconfigs
> that depend on QCOM_SCM, since that triggers lots of build errors in
> qcom_scm.
> 
> Signed-off-by: Niklas Cassel <niklas.cassel@...aro.org>
> Reviewed-by: Vivek Gautam <vivek.gautam@...eaurora.org>
> Reviewed-by: Vinod Koul <vkoul@...nel.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Regards,
Bjorn

> ---
>  drivers/soc/qcom/Kconfig | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index cf4ece232897..684cb51694d1 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -33,7 +33,7 @@ config QCOM_GLINK_SSR
>  
>  config QCOM_GSBI
>          tristate "QCOM General Serial Bus Interface"
> -        depends on ARCH_QCOM
> +        depends on ARCH_QCOM || COMPILE_TEST
>          select MFD_SYSCON
>          help
>            Say y here to enable GSBI support.  The GSBI provides control
> @@ -42,7 +42,7 @@ config QCOM_GSBI
>  
>  config QCOM_LLCC
>  	tristate "Qualcomm Technologies, Inc. LLCC driver"
> -	depends on ARCH_QCOM
> +	depends on ARCH_QCOM || COMPILE_TEST
>  	help
>  	  Qualcomm Technologies, Inc. platform specific
>  	  Last Level Cache Controller(LLCC) driver. This provides interfaces
> @@ -73,7 +73,8 @@ config QCOM_PM
>  
>  config QCOM_QMI_HELPERS
>  	tristate
> -	depends on ARCH_QCOM && NET
> +	depends on ARCH_QCOM || COMPILE_TEST
> +	depends on NET
>  	help
>  	  Helper library for handling QMI encoded messages.  QMI encoded
>  	  messages are used in communication between the majority of QRTR
> @@ -104,7 +105,7 @@ config QCOM_RPMH
>  
>  config QCOM_SMEM
>  	tristate "Qualcomm Shared Memory Manager (SMEM)"
> -	depends on ARCH_QCOM
> +	depends on ARCH_QCOM || COMPILE_TEST
>  	depends on HWSPINLOCK
>  	help
>  	  Say y here to enable support for the Qualcomm Shared Memory Manager.
> @@ -113,7 +114,7 @@ config QCOM_SMEM
>  
>  config QCOM_SMD_RPM
>  	tristate "Qualcomm Resource Power Manager (RPM) over SMD"
> -	depends on ARCH_QCOM
> +	depends on ARCH_QCOM || COMPILE_TEST
>  	depends on RPMSG
>  	help
>  	  If you say yes to this option, support will be included for the
> @@ -150,7 +151,7 @@ config QCOM_SMSM
>  
>  config QCOM_WCNSS_CTRL
>  	tristate "Qualcomm WCNSS control driver"
> -	depends on ARCH_QCOM
> +	depends on ARCH_QCOM || COMPILE_TEST
>  	depends on RPMSG
>  	help
>  	  Client driver for the WCNSS_CTRL SMD channel, used to download nv
> @@ -158,7 +159,7 @@ config QCOM_WCNSS_CTRL
>  
>  config QCOM_APR
>  	tristate "Qualcomm APR Bus (Asynchronous Packet Router)"
> -	depends on ARCH_QCOM
> +	depends on ARCH_QCOM || COMPILE_TEST
>  	depends on RPMSG
>  	help
>            Enable APR IPC protocol support between
> -- 
> 2.17.1
>