linux-kernel - Re: [Jfs-discussion] [PATCH v2 4/5] jfs: cache NULL when both default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0e37733e-9acd-cf82-62f7-420f0fa864eb@oracle.com>
Date:   Mon, 3 Sep 2018 15:34:36 -0500
From:   Dave Kleikamp <dave.kleikamp@...cle.com>
To:     Chengguang Xu <cgxu519@....com>, jack@...e.com, tytso@....edu,
        adilger.kernel@...ger.ca, jaegeuk@...nel.org, yuchao0@...wei.com,
        shaggy@...nel.org, hubcap@...ibond.com, martin@...ibond.com
Cc:     jfs-discussion@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net, linux-ext4@...r.kernel.org,
        devel@...ts.orangefs.org
Subject: Re: [Jfs-discussion] [PATCH v2 4/5] jfs: cache NULL when both
 default_acl and acl are NULL

Are you pushing these as a series, or would you like this patch pushed
through the jfs tree?

On 8/31/18 9:33 AM, Chengguang Xu wrote:
> default_acl and acl of newly created inode will be initiated
> as ACL_NOT_CACHED in vfs function inode_init_always() and later
> will be updated by calling xxx_init_acl() in specific filesystems.
> Howerver, when default_acl and acl are NULL then they keep the value
> of ACL_NOT_CACHED, this patch tries to cache NULL for acl/default_acl
> in this case.
> 
> Signed-off-by: Chengguang Xu <cgxu519@....com>

Acked-by: Dave Kleikamp <dave.kleikamp@...cle.com>

> ---
> v1->v2:
> - Coding style change.
> 
>  fs/jfs/acl.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/fs/jfs/acl.c b/fs/jfs/acl.c
> index 2e71b6e7e646..8c06a6ea862d 100644
> --- a/fs/jfs/acl.c
> +++ b/fs/jfs/acl.c
> @@ -146,12 +146,16 @@ int jfs_init_acl(tid_t tid, struct inode *inode, struct inode *dir)
>  	if (default_acl) {
>  		rc = __jfs_set_acl(tid, inode, ACL_TYPE_DEFAULT, default_acl);
>  		posix_acl_release(default_acl);
> +	} else {
> +		inode->i_default_acl = NULL;
>  	}
>  
>  	if (acl) {
>  		if (!rc)
>  			rc = __jfs_set_acl(tid, inode, ACL_TYPE_ACCESS, acl);
>  		posix_acl_release(acl);
> +	} else {
> +		inode->i_acl = NULL;
>  	}
>  
>  	JFS_IP(inode)->mode2 = (JFS_IP(inode)->mode2 & 0xffff0000) |
>