linux-kernel - Re: Make perf script easier to use for itrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180903073117.GC24575@krava>
Date:   Mon, 3 Sep 2018 09:31:18 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Kim Phillips <kim.phillips@....com>
Cc:     Andi Kleen <andi@...stfloor.org>, acme@...nel.org,
        jolsa@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: Make perf script easier to use for itrace

On Fri, Aug 31, 2018 at 05:54:53PM -0500, Kim Phillips wrote:
> On Fri, 31 Aug 2018 15:01:56 -0700
> Andi Kleen <andi@...stfloor.org> wrote:
> 
> > Also available in
> > git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc.git pt/easy-script-2
> > 
> > v1: Initial post
> > v2: Address review comments. Minor fixes to descriptions. Now builds everywhere.
> 
> OK, I grabbed the pt/easy-script-2 branch (commit 4c69fd388e17), and
> see build failures for a 'make -C perf' build using gcc version 7.3.0
> (Ubuntu 18.04):
> 
> builtin-script.c: In function ‘parse_output_fields’:
> builtin-script.c:2571:22: error: array subscript is above array bounds [-Werror=array-bounds]
>      output[j].fields &= ~all_output_options[i].field;
>                       ^~
> builtin-script.c:2571:22: error: array subscript is above array bounds [-Werror=array-bounds]
>      output[j].fields &= ~all_output_options[i].field;
>      ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> builtin-script.c:2574:10: error: array subscript is above array bounds [-Werror=array-bounds]
>     output[j].user_set = true;
>     ~~~~~~^~~
> builtin-script.c:2575:10: error: array subscript is above array bounds [-Werror=array-bounds]
>     output[j].wildcard_set = true;
>     ~~~~~~^~~
> ...
> util/cs-etm.c: In function ‘cs_etm__process_auxtrace_info’:
> util/cs-etm.c:1436:14: error: ‘struct perf_session’ has no member named ‘itrace_synth’; did you mean ‘itrace_synth_opts’?
>      session->itrace_synth.default_no_sample);
>               ^~~~~~~~~~~~
>               itrace_synth_opts

I think Andi has the new changes in pt/easy-script-3 branch,
just did not update the changelog

jirka