linux-kernel - Re: [PATCH] fat: Relax checks for sector size and media type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180903080422.ta3clnhr5bobv6il@pali>
Date:   Mon, 3 Sep 2018 10:04:22 +0200
From:   Pali Rohár <pali.rohar@...il.com>
To:     OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
Cc:     linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] fat: Relax checks for sector size and media type

On Monday 03 September 2018 17:01:03 OGAWA Hirofumi wrote:
> Pali Rohár <pali.rohar@...il.com> writes:
> 
> >> Just relaxing validation doesn't work. The block layer doesn't support
> >> smaller than 512, and lager than PAGE_SIZE.  (And in specification, fat
> >> doesn't support lager than 4096.)
> >
> > Hi! I just sent this patch for discussion, with links to (now open
> > source) Windows implementation. I guess that Windows driver
> > implementation is more "authoritative" then Microsoft's own
> > specification. It is known that Windows implementation does not match
> > Microsoft specification.
> >
> > I know at least 3 FAT specifications (MS EFI FAT, MS/SD card FAT,
> > ECMA-107) and you are right that Microsoft's one does not allow sector
> > sizes larger then 4096.
> >
> > If there is limitation by block layer, then:
> >
> > 1) Why we do not check for PAGE_SIZE?
> 
> That source seems to check power_of_2(size) and 128 <= size <=
> 4096. Rather why do you want to support larger than 4096? Or I'm missing
> something?

I looked into (Linux) mkfs.fat and it supports formatting disk also with
sector size > 4096. Therefore I thought it may be good idea for ability
to mount and use it (on Linux).

I could check what other operating system would do with FAT sector size
larger then 4096.

> > 2) Is check in fat driver really needed (if block layer checks it)?
> 
> Yes, isolating block layer error and fat format error to be better error
> report.

Ok.

-- 
Pali Rohár
pali.rohar@...il.com