[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3335422d-0b46-fde6-d172-005ba9b60d76@st.com>
Date: Mon, 3 Sep 2018 09:57:11 +0000
From: Patrice CHOTARD <patrice.chotard@...com>
To: Rob Herring <robh@...nel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC: Linus Walleij <linus.walleij@...aro.org>,
Dong Aisheng <aisheng.dong@....com>,
Fabio Estevam <festevam@...il.com>,
Shawn Guo <shawnguo@...nel.org>,
Stefan Agner <stefan@...er.ch>,
"Pengutronix Kernel Team" <kernel@...gutronix.de>,
Sean Wang <sean.wang@...iatek.com>,
"Matthias Brugger" <matthias.bgg@...il.com>,
Carlo Caione <carlo@...one.org>,
"Kevin Hilman" <khilman@...libre.com>,
Jason Cooper <jason@...edaemon.net>,
"Andrew Lunn" <andrew@...n.ch>,
Gregory Clement <gregory.clement@...tlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
"Jean-Christophe Plagniol-Villard" <plagnioj@...osoft.com>,
Nicolas Ferre <nicolas.ferre@...rochip.com>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
Heiko Stuebner <heiko@...ech.de>,
"Tony Lindgren" <tony@...mide.com>,
Haojian Zhuang <haojian.zhuang@...aro.org>,
Barry Song <baohua@...nel.org>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre TORGUE <alexandre.torgue@...com>,
Maxime Ripard <maxime.ripard@...tlin.com>,
Chen-Yu Tsai <wens@...e.org>,
"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
"linux-mediatek@...ts.infradead.org"
<linux-mediatek@...ts.infradead.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-amlogic@...ts.infradead.org"
<linux-amlogic@...ts.infradead.org>,
"linux-rockchip@...ts.infradead.org"
<linux-rockchip@...ts.infradead.org>,
"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: Convert to using %pOFn instead of
device_node.name
Hi Rob
On 08/28/2018 03:52 AM, Rob Herring wrote:
> In preparation to remove the node name pointer from struct device_node,
> convert printf users to use the %pOFn format specifier.
>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Dong Aisheng <aisheng.dong@....com>
> Cc: Fabio Estevam <festevam@...il.com>
> Cc: Shawn Guo <shawnguo@...nel.org>
> Cc: Stefan Agner <stefan@...er.ch>
> Cc: Pengutronix Kernel Team <kernel@...gutronix.de>
> Cc: Sean Wang <sean.wang@...iatek.com>
> Cc: Matthias Brugger <matthias.bgg@...il.com>
> Cc: Carlo Caione <carlo@...one.org>
> Cc: Kevin Hilman <khilman@...libre.com>
> Cc: Jason Cooper <jason@...edaemon.net>
> Cc: Andrew Lunn <andrew@...n.ch>
> Cc: Gregory Clement <gregory.clement@...tlin.com>
> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>
> Cc: Nicolas Ferre <nicolas.ferre@...rochip.com>
> Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>
> Cc: Heiko Stuebner <heiko@...ech.de>
> Cc: Tony Lindgren <tony@...mide.com>
> Cc: Haojian Zhuang <haojian.zhuang@...aro.org>
> Cc: Patrice Chotard <patrice.chotard@...com>
> Cc: Barry Song <baohua@...nel.org>
> Cc: Maxime Coquelin <mcoquelin.stm32@...il.com>
> Cc: Alexandre Torgue <alexandre.torgue@...com>
> Cc: Maxime Ripard <maxime.ripard@...tlin.com>
> Cc: Chen-Yu Tsai <wens@...e.org>
> Cc: linux-gpio@...r.kernel.org
> Cc: linux-mediatek@...ts.infradead.org
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-amlogic@...ts.infradead.org
> Cc: linux-rockchip@...ts.infradead.org
> Cc: linux-omap@...r.kernel.org
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
> drivers/pinctrl/berlin/berlin.c | 6 ++--
> drivers/pinctrl/freescale/pinctrl-imx.c | 7 ++--
> drivers/pinctrl/freescale/pinctrl-imx1-core.c | 12 +++----
> drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 4 +--
> drivers/pinctrl/meson/pinctrl-meson.c | 2 +-
> drivers/pinctrl/mvebu/pinctrl-mvebu.c | 4 +--
> drivers/pinctrl/nomadik/pinctrl-nomadik.c | 6 ++--
> drivers/pinctrl/pinctrl-at91.c | 8 ++---
> drivers/pinctrl/pinctrl-lantiq.c | 8 ++---
> drivers/pinctrl/pinctrl-rockchip.c | 8 ++---
> drivers/pinctrl/pinctrl-rza1.c | 8 ++---
> drivers/pinctrl/pinctrl-single.c | 32 +++++++++----------
> drivers/pinctrl/pinctrl-st.c | 6 ++--
> drivers/pinctrl/sirf/pinctrl-atlas7.c | 4 +--
> drivers/pinctrl/stm32/pinctrl-stm32.c | 4 +--
> drivers/pinctrl/sunxi/pinctrl-sunxi.c | 8 ++---
> drivers/pinctrl/ti/pinctrl-ti-iodelay.c | 8 ++---
> 17 files changed, 66 insertions(+), 69 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index 0966bb0bf71f..e66af93f2cbf 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -817,8 +817,8 @@ static int st_pctl_dt_node_to_map(struct pinctrl_dev *pctldev,
>
> grp = st_pctl_find_group_by_name(info, np->name);
> if (!grp) {
> - dev_err(info->dev, "unable to find group for node %s\n",
> - np->name);
> + dev_err(info->dev, "unable to find group for node %pOFn\n",
> + np);
> return -EINVAL;
> }
>
> @@ -1184,7 +1184,7 @@ static int st_pctl_dt_parse_groups(struct device_node *np,
> if (pp->length / sizeof(__be32) >= OF_GPIO_ARGS_MIN) {
> npins++;
> } else {
> - pr_warn("Invalid st,pins in %s node\n", np->name);
> + pr_warn("Invalid st,pins in %pOFn node\n", np);
> return -EINVAL;
> }
> }
For pinctrl-st:
Acked-by: Patrice Chotard <patrice.chotard@...com>
Thanks
Patrice
Powered by blists - more mailing lists