linux-kernel - Re: [PATCH] ASoC: tlv320aic31xx: Add MICBIAS off setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180903112656.GF10302@sirena.org.uk>
Date:   Mon, 3 Sep 2018 12:26:56 +0100
From:   Mark Brown <broonie@...nel.org>
To:     "Andrew F. Davis" <afd@...com>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: tlv320aic31xx: Add MICBIAS off setting

On Fri, Aug 31, 2018 at 01:05:07PM -0500, Andrew F. Davis wrote:
> Leaving microphone bias off is a valid setting and even used in the DT
> binding document example. Add this setting here and document the same.
> Although it may not make much sense to enable a microphone here without
> any bias, it is a valid setting that can be chosen by DT and may be
> needed for some boards.

If we really want to pay attention to something setting this up we'd
need to completely remove the widget - what the code is doing at the
minute is setting the voltage that the bias will go to when enabled,
there's still a widget for turning it on and off.  There's some chance
that this will break existing boards.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)