lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 3 Sep 2018 14:15:07 +0200 From: Ulf Hansson <ulf.hansson@...aro.org> To: Ludovic Barre <ludovic.Barre@...com> Cc: Rob Herring <robh+dt@...nel.org>, Maxime Coquelin <mcoquelin.stm32@...il.com>, Alexandre Torgue <alexandre.torgue@...com>, Gerald Baeza <gerald.baeza@...com>, Linux ARM <linux-arm-kernel@...ts.infradead.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, DTML <devicetree@...r.kernel.org>, "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org> Subject: Re: [PATCH 03/14] mmc: mmci: internalize dma_inprogress into mmci dma functions On 1 August 2018 at 11:36, Ludovic Barre <ludovic.Barre@...com> wrote: > From: Ludovic Barre <ludovic.barre@...com> > > This patch internalizes the dma_inprogress into mmci dma interfaces. > This allows to simplify and prepare the next dma callbacks > for mmci host ops. __dma_inprogress is called in mmci_dma_data_error > and mmci_dma_finalize. > > Signed-off-by: Ludovic Barre <ludovic.barre@...com> [...] > diff --git a/drivers/mmc/host/mmci.h b/drivers/mmc/host/mmci.h > index 696a066..f1ec066 100644 > --- a/drivers/mmc/host/mmci.h > +++ b/drivers/mmc/host/mmci.h > @@ -332,9 +332,7 @@ struct mmci_host { > struct mmci_host_next next_data; > bool dma_in_progress; > > -#define dma_inprogress(host) ((host)->dma_in_progress) > -#else > -#define dma_inprogress(host) (0) > +#define __dma_inprogress(host) ((host)->dma_in_progress) Please keep the existing function name. If there are good reasons to change it, please make it a part of a change where it makes sense. > #endif > }; > > -- > 2.7.4 > Besides the nitpick above, this looks good to me! Kind regards Uffe
Powered by blists - more mailing lists