linux-kernel - RE: [PATCH 1/2] ARM: dts: imx7s: enable cpuidle driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM6PR0402MB3911E04E1DF1CB7FE55B47CAF50C0@AM6PR0402MB3911.eurprd04.prod.outlook.com>
Date:   Mon, 3 Sep 2018 01:50:48 +0000
From:   Anson Huang <anson.huang@....com>
To:     Shawn Guo <shawnguo@...nel.org>
CC:     "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH 1/2] ARM: dts: imx7s: enable cpuidle driver



Anson Huang
Best Regards!


> -----Original Message-----
> From: Shawn Guo <shawnguo@...nel.org>
> Sent: Monday, September 3, 2018 9:16 AM
> To: Anson Huang <anson.huang@....com>
> Cc: s.hauer@...gutronix.de; kernel@...gutronix.de; Fabio Estevam
> <fabio.estevam@....com>; robh+dt@...nel.org; mark.rutland@....com;
> linux@...linux.org.uk; linux-arm-kernel@...ts.infradead.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; dl-linux-imx
> <linux-imx@....com>
> Subject: Re: [PATCH 1/2] ARM: dts: imx7s: enable cpuidle driver
> 
> On Wed, Aug 29, 2018 at 01:00:46PM +0800, Anson Huang wrote:
> > Enable cpuidle for i.MX7S/D using generic ARM cpuidle driver, below 2
> > idle states enabled:
> >
> > 1. ARM WFI;
> > 2. SoC WAIT mode.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@....com>
> > ---
> >  arch/arm/boot/dts/imx7d.dtsi |  1 +
> >  arch/arm/boot/dts/imx7s.dtsi | 14 ++++++++++++++
> >  2 files changed, 15 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx7d.dtsi
> > b/arch/arm/boot/dts/imx7d.dtsi index 7cbc2ff..4d0d0f6 100644
> > --- a/arch/arm/boot/dts/imx7d.dtsi
> > +++ b/arch/arm/boot/dts/imx7d.dtsi
> > @@ -20,6 +20,7 @@
> >  			reg = <1>;
> >  			clock-frequency = <996000000>;
> >  			operating-points-v2 = <&cpu0_opp_table>;
> > +			cpu-idle-states = <&CPU_SLEEP>;
> >  		};
> >  	};
> >
> > diff --git a/arch/arm/boot/dts/imx7s.dtsi
> > b/arch/arm/boot/dts/imx7s.dtsi index 93884ce..cf5570b 100644
> > --- a/arch/arm/boot/dts/imx7s.dtsi
> > +++ b/arch/arm/boot/dts/imx7s.dtsi
> > @@ -54,6 +54,19 @@
> >  		#address-cells = <1>;
> >  		#size-cells = <0>;
> >
> > +		idle-states {
> > +			entry-method = "psci";
> > +
> > +			CPU_SLEEP: WAIT {
> 
> I understand uppercase is allowed, but we conventionally use lowercase for
> label and node name.  Can we do something like below?
> 
> 	cpu_sleep_wait: cpu-sleep-wait {
> 		...
> 	}
 
Sure, please review V2 patch, thanks!

Anson

> 
> Shawn
> 
> > +				compatible = "arm,idle-state";
> > +				arm,psci-suspend-param = <0x0010000>;
> > +				local-timer-stop;
> > +				entry-latency-us = <100>;
> > +				exit-latency-us = <50>;
> > +				min-residency-us = <1000>;
> > +			};
> > +		};
> > +
> >  		cpu0: cpu@0 {
> >  			compatible = "arm,cortex-a7";
> >  			device_type = "cpu";
> > @@ -61,6 +74,7 @@
> >  			clock-frequency = <792000000>;
> >  			clock-latency = <61036>; /* two CLK32 periods */
> >  			clocks = <&clks IMX7D_CLK_ARM>;
> > +			cpu-idle-states = <&CPU_SLEEP>;
> >  		};
> >  	};
> >
> > --
> > 2.7.4
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@...ts.infradead.org
> > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flist
> >
> s.infradead.org%2Fmailman%2Flistinfo%2Flinux-arm-kernel&amp;data=02%7C
> >
> 01%7CAnson.Huang%40nxp.com%7C8ce1cddcac05444edc1408d6113b0a76%7
> C686ea1
> >
> d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636715342610651079&amp;sda
> ta=x9l%
> >
> 2FrkV8Uo8CtSa0jJsBZ%2FXt2DE3ZRQ5TWXm5%2Fbwvag%3D&amp;reserved=
> 0