linux-kernel - Re: [PATCH v2 3/3] x86/speculation: Enable cross-hyperthread spectre v2 STIBP mitigation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180903143656.GD24142@hirez.programming.kicks-ass.net>
Date:   Mon, 3 Sep 2018 16:36:56 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Jiri Kosina <jikos@...nel.org>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Andrea Arcangeli <aarcange@...hat.com>,
        "Woodhouse, David" <dwmw@...zon.co.uk>,
        linux-kernel@...r.kernel.org, x86@...nel.org,
        Oleg Nesterov <oleg@...hat.com>,
        Tim Chen <tim.c.chen@...ux.intel.com>
Subject: Re: [PATCH v2 3/3] x86/speculation: Enable cross-hyperthread spectre
 v2 STIBP mitigation

On Mon, Sep 03, 2018 at 04:34:44PM +0200, Peter Zijlstra wrote:
> On Mon, Sep 03, 2018 at 02:45:31PM +0200, Jiri Kosina wrote:
> 
> > +static bool __init stibp_needed(void)
> > +{
> > +	return (cpu_smt_control != CPU_SMT_NOT_SUPPORTED &&
> > +			boot_cpu_has(X86_FEATURE_STIBP));
> > +}
> 
> Should that not be:
> 
> 	((cpu_smt_control != CPU_SMT_NOT_SUPPORTED) ||

s/||/&&/

> 	 (cpu_smt_control != CPU_SMT_FORCE_DISABLED)) &&
> 	boot_cpu_has(X86_FEATURE_STIBP);
> 
> instead?