linux-kernel - Re: [PATCH v2 1/2] iio: adc: sc27xx: Add raw data support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMz4kuJYWkuQk9et-odco49r2AMeMpyqAPcYDsq72L4Ko41VuQ@mail.gmail.com>
Date:   Mon, 3 Sep 2018 10:20:14 +0800
From:   Baolin Wang <baolin.wang@...aro.org>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        freeman.liu@...eadtrum.com, Mark Brown <broonie@...nel.org>,
        DTML <devicetree@...r.kernel.org>, linux-iio@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] iio: adc: sc27xx: Add raw data support

Hi Jonathan,

On 2 September 2018 at 16:51, Jonathan Cameron <jic23@...nel.org> wrote:
> On Wed, 29 Aug 2018 14:04:04 +0800
> Baolin Wang <baolin.wang@...aro.org> wrote:
>
>> The headset device will use channel 20 of ADC controller to detect events,
>> but it needs the raw ADC data to do conversion according to its own formula.
>>
>> Thus we should configure the channel mask separately and configure channel
>> 20 as IIO_CHAN_INFO_RAW, as well as adding raw data read support.
>>
>> Signed-off-by: Baolin Wang <baolin.wang@...aro.org>
> I'm still a little unclear on whether there is fundamentally something different
> about this channel or whether this is just a policy decision for particular
> (possibly all) board.  For now we'll go with this change, but if anyone screams
> we will have to then go the nasty route of supporting both processed and raw
> for channel 20.

Until now, channel 20 is always used for the headset on the SC27xx
series PMICs. Yes, this is a policy decision, but for all the SC27xx
series PMICs.

>
> Applied to the togreg branch of iio.git and pushed out as testing for the
> autobuilders to play with it.

Thanks.

-- 
Baolin Wang
Best Regards