linux-kernel - Re: [PATCH 1/4] staging: comedi: Correct multiline dereference as per TODO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4b023c3d-eaeb-6466-5bc8-caed57fbd48b@mev.co.uk>
Date:   Mon, 3 Sep 2018 15:52:21 +0100
From:   Ian Abbott <abbotti@....co.uk>
To:     Ray Clinton <mr.ray.clinton@...il.com>, greg@...ah.com
Cc:     hsweeten@...ionengravers.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] staging: comedi: Correct multiline dereference as per
 TODO

On 03/09/18 15:47, Ian Abbott wrote:
> On 30/08/18 18:32, Ray Clinton wrote:
>> Using checkpatch.pl I was able to find a multiline dereference which goes
>> again the coding style for the kernel. I'm still working on my email 
>> client so
>> the indentation looks bad here (in gmail) but the arguments for
>> comedi_check_trigger_arg_min should go just under the opening (
> 
> The patch description should describe what the patch does, not how bad 
> the indentation loos in your email client.

"loos" ==> "looks"

Also, you sent 4 patches with the same subject line (other than the 
PATCH 1/4 part).  They should be different.  You can include the driver 
name in the patch subject line to distinguish them, e.g.:

staging: comedi: dt3000: Correct multiline dereference

-- 
-=( Ian Abbott <abbotti@....co.uk> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268.  Registered address:    )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-