linux-kernel - Re: [PATCH v3] kmemleak: add module param to print warnings to dmesg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180903150229.zwyc7nrjpacnwag3@armageddon.cambridge.arm.com>
Date:   Mon, 3 Sep 2018 16:02:30 +0100
From:   Catalin Marinas <catalin.marinas@....com>
To:     Vincent Whitchurch <vincent.whitchurch@...s.com>
Cc:     akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, Vincent Whitchurch <rabinv@...s.com>
Subject: Re: [PATCH v3] kmemleak: add module param to print warnings to dmesg

On Mon, Sep 03, 2018 at 04:40:46PM +0200, Vincent Whitchurch wrote:
> Currently, kmemleak only prints the number of suspected leaks to dmesg
> but requires the user to read a debugfs file to get the actual stack
> traces of the objects' allocation points.  Add a module option to print
> the full object information to dmesg too.  It can be enabled with
> kmemleak.verbose=1 on the kernel command line, or "echo 1 >
> /sys/module/kmemleak/parameters/verbose":
> 
> This allows easier integration of kmemleak into test systems:  We have
> automated test infrastructure to test our Linux systems.  With this
> option, running our tests with kmemleak is as simple as enabling
> kmemleak and passing this command line option; the test infrastructure
> knows how to save kernel logs, which will now include kmemleak reports.
> Without this option, the test infrastructure needs to be specifically
> taught to read out the kmemleak debugfs file.  Removing this need for
> special handling makes kmemleak more similar to other kernel debug
> options (slab debugging, debug objects, etc).
> 
> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@...s.com>
> ---
> v3: Expand use case description.  Replace config option with module parameter.
> 
>  mm/kmemleak.c | 42 +++++++++++++++++++++++++++++++++++-------
>  1 file changed, 35 insertions(+), 7 deletions(-)

Acked-by: Catalin Marinas <catalin.marinas@....com>