linux-kernel - Re: [PATCH net-next] i40e: remove inline directive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b7bfa13d-d33d-87f1-6f0a-95d040610847@cogentembedded.com>
Date:   Mon, 3 Sep 2018 19:05:05 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     YueHaibing <yuehaibing@...wei.com>, davem@...emloft.net,
        jeffrey.t.kirsher@...el.com
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        intel-wired-lan@...ts.osuosl.org
Subject: Re: [PATCH net-next] i40e: remove inline directive

On 09/03/2018 03:36 PM, YueHaibing wrote:

> Fixes follow gcc warning:
> 
> drivers/net/ethernet/intel/i40e/i40e_ethtool.c: In function '__i40e_add_stat_strings':
> drivers/net/ethernet/intel/i40e/i40e_ethtool_stats.h:193:20: error: function '__i40e_add_stat_strings' can never be inlined because it uses variable argument lists
> 
> Fixes: 8fd75c58a09a ("i40e: move ethtool stats boiler plate code to i40e_ethtool_stats.h")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_ethtool_stats.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool_stats.h b/drivers/net/ethernet/intel/i40e/i40e_ethtool_stats.h
> index bba1cb0..0290ade 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool_stats.h
> +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool_stats.h
> @@ -190,7 +190,7 @@ i40e_add_queue_stats(u64 **data, struct i40e_ring *ring)
>   * Format and copy the strings described by stats into the buffer pointed at
>   * by p.
>   **/
> -static inline void __i40e_add_stat_strings(u8 **p, const struct i40e_stats stats[],
> +static void __i40e_add_stat_strings(u8 **p, const struct i40e_stats stats[],
>  				    const unsigned int size, ...)
>  {
>  	unsigned int i;

   You now need to move this function to a .c file and leave here only its prototype.

MBR, Sergei