linux-kernel - Re: [PATCH] linux/mod_devicetable.h: fix kernel-doc missing notation for typec_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180904074034.GG15112@kuha.fi.intel.com>
Date:   Tue, 4 Sep 2018 10:40:34 +0300
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        USB list <linux-usb@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] linux/mod_devicetable.h: fix kernel-doc missing notation
 for typec_device_id

On Mon, Sep 03, 2018 at 12:51:59PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@...radead.org>
> 
> Fix kernel-doc warning for missing struct member description:
> 
> ../include/linux/mod_devicetable.h:763: warning: Function parameter or member 'driver_data' not described in 'typec_device_id'
> 
> Fixes: 8a37d87d72f0c ("usb: typec: Bus type for alternate modes")
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
>  include/linux/mod_devicetable.h |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- lnx-419-rc2.orig/include/linux/mod_devicetable.h
> +++ lnx-419-rc2/include/linux/mod_devicetable.h
> @@ -754,6 +754,7 @@ struct tb_service_id {
>   * struct typec_device_id - USB Type-C alternate mode identifiers
>   * @svid: Standard or Vendor ID
>   * @mode: Mode index
> + * @driver_data: Driver specific data
>   */
>  struct typec_device_id {
>  	__u16 svid;
> 

Thanks,

-- 
heikki