linux-kernel - Re: [PATCH v2] fs: Convert return type int to vm_fault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180903172843.9bf312c738ce8a434dd9c242@linux-foundation.org>
Date:   Mon, 3 Sep 2018 17:28:43 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Souptick Joarder <jrdr.linux@...il.com>
Cc:     Ryusuke Konishi <konishi.ryusuke@....ntt.co.jp>,
        Al Viro <viro@...iv.linux.org.uk>,
        "Theodore Ts'o" <tytso@....edu>, adilger.kernel@...ger.ca,
        Jens Axboe <axboe@...nel.dk>,
        "Darrick J. Wong" <darrick.wong@...cle.com>,
        Eric Biggers <ebiggers@...gle.com>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Andreas Gruenbacher <agruenba@...hat.com>,
        Greg KH <gregkh@...uxfoundation.org>, kemi.wang@...el.com,
        Matthew Wilcox <willy@...radead.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        linux-kernel@...r.kernel.org, linux-ext4@...r.kernel.org,
        linux-nilfs <linux-nilfs@...r.kernel.org>
Subject: Re: [PATCH v2] fs: Convert return type int to vm_fault_t

On Fri, 31 Aug 2018 11:33:48 +0530 Souptick Joarder <jrdr.linux@...il.com> wrote:

> > > Return type of block_page_mkwrite_return() is also changed
> > > to use new vm_fault_t type.
> > > --- a/fs/nilfs2/file.c
> > > +++ b/fs/nilfs2/file.c
> > > @@ -51,13 +51,14 @@ int nilfs_sync_file(struct file *file, loff_t start, loff_t end, int datasync)
> > >       return err;
> > >  }
> > >
> > > -static int nilfs_page_mkwrite(struct vm_fault *vmf)
> > > +static vm_fault_t nilfs_page_mkwrite(struct vm_fault *vmf)
> >
> > nilfs_page_mkwrite() already has return type vm_fault_t in Linus's
> > kernel, due to the now-merged
> > fs-nilfs2-adding-new-return-type-vm_fault_t.patch.  Looks like a simple
> > fix.
> >
> > I'm beginning to feel vm_fault_t exhaustion.  Please remind me what
> > benefit we're going to get out of all this churn?
> 
> The problem and benefit of these changes was discussed under this mail
> thread when the first vm_fault_t patch was posted.
> 
> https://marc.info/?l=linux-mm&m=152054772413234&w=4

That tells us about the merging plans.  But not much about what actual
benefit anyone gets from this.

This?

: There's some interesting patterns and commonalities between drivers
: (not to mention a few outright bugs) that we've noticed, and this'll be
: a good time to clean them up.

That is terribly vague.