linux-kernel - RE: [PATCH v3] EDAC, ghes: use CPER module handles to locate DIMMs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <003601d44452$531d4060$f957c120$@codeaurora.org>
Date:   Tue, 4 Sep 2018 07:22:25 -0600
From:   "wufan" <wufan@...eaurora.org>
To:     "'Borislav Petkov'" <bp@...en8.de>
Cc:     <mchehab@...nel.org>, <james.morse@....com>,
        <baicar.tyler@...il.com>, <linux-edac@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <john.garry@...wei.com>,
        <toshi.kani@....com>, <tanxiaofei@...wei.com>,
        <wanghuiqiang@...wei.com>, <shiju.jose@...wei.com>
Subject: RE: [PATCH v3] EDAC, ghes: use CPER module handles to locate DIMMs



> -----Original Message-----
> From: Borislav Petkov <bp@...en8.de>
> Sent: Tuesday, September 4, 2018 1:29 AM
> To: Fan Wu <wufan@...eaurora.org>
> Cc: mchehab@...nel.org; james.morse@....com; baicar.tyler@...il.com;
> linux-edac@...r.kernel.org; linux-kernel@...r.kernel.org; linux-arm-
> kernel@...ts.infradead.org; john.garry@...wei.com; toshi.kani@....com;
> tanxiaofei@...wei.com; wanghuiqiang@...wei.com;
> shiju.jose@...wei.com
> Subject: Re: [PATCH v3] EDAC, ghes: use CPER module handles to locate
> DIMMs
> 
> On Tue, Sep 04, 2018 at 03:50:55AM +0000, Fan Wu wrote:
> > For platforms whose firmwares provide valid module handles (SMBIOS
> > type 17) in error records, this patch uses the module handles to
> > locate corresponding DIMMs and enables per-DIMM error counter update.
> >
> > Signed-off-by: Fan Wu <wufan@...eaurora.org>
> > Reviewed-by: Tyler Baicar <baicar.tyler@...il.com>
> > Tested-by: Toshi Kani <toshi.kani@....com>
> 
> Those two tags I did see being given to you ...
> 
> > Reviewed-by: Borislav Petkov <bp@...en8.de>
> > Reviewed-by: James Morse <james.morse@....com>
> > Reviewed-by: tanxiaofei <tanxiaofei@...wei.com>
>
> ... but how in the world did you come up with those?

Sorry. Will remove these in v4. 
Thanks,
Fan

 
> Do you understand how Reviewed-by works or do you need to look at
> Documentation/process/submitting-patches.rst, section 13 ?
> 
> --
> Regards/Gruss,
>     Boris.
> 
> Good mailing practices for 400: avoid top-posting and trim the reply.