linux-kernel - Re: [PATCH 2/4] ASoC: tlv320aic31xx: Add overflow detection support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <274b9d82-542b-dbf7-94e2-a61bc6eb2bbc@ti.com>
Date:   Tue, 4 Sep 2018 09:38:24 -0500
From:   "Andrew F. Davis" <afd@...com>
To:     Mark Brown <broonie@...nel.org>
CC:     Liam Girdwood <lgirdwood@...il.com>, <alsa-devel@...a-project.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/4] ASoC: tlv320aic31xx: Add overflow detection support

On 09/03/2018 08:03 AM, Mark Brown wrote:
> On Fri, Aug 31, 2018 at 01:24:32PM -0500, Andrew F. Davis wrote:
>> Similar to short circuit detection, when the ADC/DAC is saturated and
>> overflows poor audio quality can result and should be reported to the
>> user. This device support Automatic Dynamic Range Compression (DRC)
>> to reduce this but it is not enabled currently in this driver.
> 
>> +	if (value & AIC31XX_DAC_OF_LEFT)
>> +		dev_err(dev, "Left-channel DAC overflow has occurred\n");
>> +	if (value & AIC31XX_DAC_OF_RIGHT)
>> +		dev_err(dev, "Right-channel DAC overflow has occurred\n");
> 
> So, this will sound terrible but I'm not sure that unconditionally
> shouting in the logs is the right thing to do here - people do sometimes
> put non-audio signals through sound cards (using them as generic DACs
> and ADCs) and it seems like it could get very spammy.  Perhaps a lower
> level warning message, some counters or even some control that allows
> the warnings to be masked.
> 

As these events do not stop the function of the sound card, I agree
warnings would be more appropriate than errors, I'll make that change.

Andrew