linux-kernel - Re: [PATCH v2] libnvdimm, region_devs: stop NDD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 4 Sep 2018 08:57:47 -0700
From:   Dan Williams <dan.j.williams@...el.com>
To:     Ocean He <oceanhehy@...il.com>
Cc:     Ross Zwisler <ross.zwisler@...ux.intel.com>,
        Vishal L Verma <vishal.l.verma@...el.com>,
        Dave Jiang <dave.jiang@...el.com>,
        linux-nvdimm <linux-nvdimm@...ts.01.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Ocean He <hehy1@...ovo.com>
Subject: Re: [PATCH v2] libnvdimm, region_devs: stop NDD_ALIASING bit test if
 one test pass

On Tue, Sep 4, 2018 at 3:47 AM, Ocean He <oceanhehy@...il.com> wrote:
> From: Ocean He <hehy1@...ovo.com>
>
> There is no need to finish entire loop to execute NDD_ALIASING bit test
> against every nvdimm->flags.

Of course there is. I see nothing stopping someone mixing an NVDIMM
that supports labels with one that doesn't. If anything I think we
need fixes to make sure this operates correctly to force disable
BLK-mode capactiy when the PMEM capacity is interleaved with a
label-less NVDIMM.