linux-kernel - Re: [PATCH v4 6/8] perf, tools, script: Make itrace script default to all calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180904143836.43f1c07134e25bda6fa0842c@arm.com>
Date:   Tue, 4 Sep 2018 14:38:36 -0500
From:   Kim Phillips <kim.phillips@....com>
To:     Andi Kleen <andi@...stfloor.org>
Cc:     <acme@...nel.org>, <jolsa@...nel.org>, <adrian.hunter@...el.com>,
        <linux-kernel@...r.kernel.org>, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH v4 6/8] perf, tools, script: Make itrace script default
 to all calls

On Mon, 3 Sep 2018 09:22:47 -0700
Andi Kleen <andi@...stfloor.org> wrote:

<snip>
> Fix ETM build failure
> ---
> diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c
> index 2ae640257fdb..0296405f38b2 100644
> --- a/tools/perf/util/cs-etm.c
> +++ b/tools/perf/util/cs-etm.c
> @@ -1432,7 +1432,8 @@ int cs_etm__process_auxtrace_info(union perf_event *event,
>  	if (session->itrace_synth_opts && session->itrace_synth_opts->set) {
>  		etm->synth_opts = *session->itrace_synth_opts;
>  	} else {
> -		itrace_synth_opts__set_default(&etm->synth_opts);
> +		itrace_synth_opts__set_default(&etm->synth_opts,
> +				etm->synth_opts->default_no_sample);

This still fails but with a different error:

  CC       util/cs-etm.o
util/cs-etm.c: In function ‘cs_etm__process_auxtrace_info’:
util/cs-etm.c:1436:20: error: invalid type argument of ‘->’ (have ‘struct itrace_synth_opts’)
     etm->synth_opts->default_no_sample);
                    ^~

I tried this diff, and it built:

diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c
index 0296405f38b2..3b37d66dc533 100644
--- a/tools/perf/util/cs-etm.c
+++ b/tools/perf/util/cs-etm.c
@@ -1433,7 +1433,7 @@ int cs_etm__process_auxtrace_info(union perf_event *event,
                etm->synth_opts = *session->itrace_synth_opts;
        } else {
                itrace_synth_opts__set_default(&etm->synth_opts,
-                               etm->synth_opts->default_no_sample);
+                               session->itrace_synth_opts->default_no_sample);
                etm->synth_opts.callchain = false;
        }
 
So please incorporate it in this patch.

FYI, building-in cs-etm decoding into perf depends on
CONFIG_LIBOPENCSD.  Debian has a package 'libopencsd' that provides
it.  I don't know about other distros, but it's possible to build and
install the library from scratch:

https://github.com/Linaro/OpenCSD/

Thanks,

Kim