[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180904230240.GK27886@tassilo.jf.intel.com>
Date: Tue, 4 Sep 2018 16:02:40 -0700
From: Andi Kleen <ak@...ux.intel.com>
To: Eduardo Valentin <eduval@...zon.com>
Cc: Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...hat.com>,
"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
Peter Zijlstra <peterz@...radead.org>,
Kan Liang <kan.liang@...ux.intel.com>,
Dan Carpenter <dan.carpenter@...cle.com>,
Jia Zhang <qianyue.zj@...baba-inc.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2 1/1] perf/x86/intel: make error messages less confusing
On Tue, Sep 04, 2018 at 11:23:12AM -0700, Eduardo Valentin wrote:
> Hello,
>
> On Thu, Aug 23, 2018 at 08:07:32AM -0700, Eduardo Valentin wrote:
> > On a system with X86_FEATURE_ARCH_PERFMON disabled
> > and with a model not known by family PMU drivers,
> > user gets a kernel message log like the following:
> > [ 0.100114] Performance Events: unsupported p6 CPU model 85 no PMU driver, software events only.
> >
> > The "unsupported .. CPU" part may be confusing for some
> > users leading to wrong understanding that the kernel
> > does not support the CPU model.
> >
> > This patch rewords the messages on the failure path to:
> > [ 0.667154] Performance Events: CPU does not support PMU: no PMU driver, software events only.
> >
>
>
> Gentle ping on this patch, any further comments?
Reviewed-by: Andi Kleen <ak@...ux.intel.com>
-Andi
Powered by blists - more mailing lists