lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 4 Sep 2018 17:16:31 -0700 From: Kees Cook <keescook@...omium.org> To: Harald Freudenberger <freude@...ux.ibm.com> Cc: Martin Schwidefsky <schwidefsky@...ibm.com>, linux-kernel <linux-kernel@...r.kernel.org>, linux-s390 <linux-s390@...r.kernel.org>, Heiko Carstens <heiko.carstens@...ibm.com> Subject: Re: [GIT PULL] s390 patches for the 4.19 merge window #2 On Fri, Aug 24, 2018 at 12:42 AM, Martin Schwidefsky <schwidefsky@...ibm.com> wrote: > Harald Freudenberger (5): > s390/zcrypt: hex string mask improvements for apmask and aqmask. This (and an earlier 2017 commit) adds VLAs, which are being removed[1] from the kernel: drivers/s390/crypto/ap_bus.c:980:3: warning: ISO C90 forbids variable length array ‘clrm’ [-Wvla] drivers/s390/crypto/ap_bus.c:981:3: warning: ISO C90 forbids variable length array ‘setm’ [-Wvla] drivers/s390/crypto/ap_bus.c:995:3: warning: ISO C90 forbids variable length array ‘setm’ [-Wvla] static int process_mask_arg(const char *str, unsigned long *bitmap, int bits, struct mutex *lock) ... DECLARE_BITMAP(clrm, bits); DECLARE_BITMAP(setm, bits); Can someone please adjust this to make these fixed size again? Thanks! -Kees [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com -- Kees Cook Pixel Security
Powered by blists - more mailing lists