linux-kernel - Re: [PATCH] kbuild: modules_install: Warn if System.map file is not found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNATshpTJ5sDH7pMzBbhd-zF7Yskv6ptiysn1X+pHB1Z8Dw@mail.gmail.com>
Date:   Wed, 5 Sep 2018 16:17:51 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kbuild <linux-kbuild@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kbuild: modules_install: Warn if System.map file is not found

Hi Randy,

2018-09-01 7:33 GMT+09:00 Randy Dunlap <rdunlap@...radead.org>:
> From: Randy Dunlap <rdunlap@...radead.org>
>
> If there is no System.map file for "make modules_install",
> scripts/depmod.sh will silently exit with success, having done
> nothing.  Since this is an unexpected situation, change it to
> report a Warning for the missing file.  The behavior is not
> changed except for the Warning message.
>
> The (previous) silent success and new Warning can be reproduced
> by:
> $ make mrproper; make defconfig
> $ make modules; make modules_install
>
> and since System.map is produced by "make vmlinux", the steps
> above omit producing the System.map file.
>
> Reported-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> Cc: Masahiro Yamada <yamada.masahiro@...ionext.com>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> ---
>  scripts/depmod.sh |    1 +
>  1 file changed, 1 insertion(+)
>
> --- lnx-419-rc1.orig/scripts/depmod.sh
> +++ lnx-419-rc1/scripts/depmod.sh
> @@ -11,6 +11,7 @@ DEPMOD=$1
>  KERNELRELEASE=$2
>
>  if ! test -r System.map ; then
> +       echo "Warning: modules_install: missing 'System.map' file"
>         exit 0
>  fi

Thanks for the patch.


For consistency, I'd like to suggest '>&2' for this warning too.


Also, could you add a little more info
about what happened (or what did not happen) then ?



For example,


Warning: modules_install: missing 'System.map' file.  Skipping depmod.





-- 
Best Regards
Masahiro Yamada