[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180905081315.bdbotkyfpdkdj537@mwanda>
Date: Wed, 5 Sep 2018 11:13:15 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: Michael Straube <straube.linux@...il.com>
Cc: gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] staging: rtl8188eu: remove empty if statement in
rtw_led.c
On Tue, Sep 04, 2018 at 01:16:15PM +0200, Michael Straube wrote:
> Remove empty if statement from 'if - else if' and replace the
> else if with if. Remove the now unused variable pmlmepriv.
> Also clears line over 80 characters and CamelCase checkpatch
> issues.
>
> Signed-off-by: Michael Straube <straube.linux@...il.com>
> ---
> drivers/staging/rtl8188eu/core/rtw_led.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_led.c b/drivers/staging/rtl8188eu/core/rtw_led.c
> index cbef871a7679..39904ab284fd 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_led.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_led.c
> @@ -239,7 +239,6 @@ static void SwLedControlMode1(struct adapter *padapter, enum LED_CTL_MODE LedAct
> {
> struct led_priv *ledpriv = &padapter->ledpriv;
> struct LED_871x *pLed = &ledpriv->SwLed0;
> - struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
>
> switch (LedAction) {
> case LED_CTL_POWER_ON:
> @@ -290,9 +289,7 @@ static void SwLedControlMode1(struct adapter *padapter, enum LED_CTL_MODE LedAct
> }
> break;
> case LED_CTL_SITE_SURVEY:
> - if ((pmlmepriv->LinkDetectInfo.bBusyTraffic) && (check_fwstate(pmlmepriv, _FW_LINKED))) {
> - ;
> - } else if (!pLed->bLedScanBlinkInProgress) {
> + if (!pLed->bLedScanBlinkInProgress) {
I think you have introduced a bug...
regards,
dan carpenter
Powered by blists - more mailing lists