linux-kernel - Re: [PATCH] USB: serial: ftdi_sio: implement GPIO support for FT230X

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180905082131.GV28861@localhost>
Date:   Wed, 5 Sep 2018 10:21:31 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Karoly Pados <pados@...os.hu>
Cc:     Johan Hovold <johan@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Loic Poulain <loic.poulain@...aro.org>,
        andy.shevchenko@...il.com, ajaykuee@...il.com,
        daniel.thompson@...aro.org
Subject: Re: [PATCH] USB: serial: ftdi_sio: implement GPIO support for FT230X

On Tue, Sep 04, 2018 at 06:07:49PM +0000, Karoly Pados wrote:
> >>> + priv->gc.ngpio = 4;
> >> 
> >> Shouldn't this be handled the other way round? IIRC there are two FTX
> >> device types with four pins, and one type where only one pin is
> >> accessible.
> > 
> > There are 4 devices with 1 GPIO, 1 device with 2 GPIOs, 2 devices with 4 GPIOs,
> > and 1 device with 6 GPIOs. Source: http://www.ftdichip.com/FT-X.htm (2nd table)
> > Do you still want me turn this over?
> > 
> 
> Aaah, but those other devices are not UART bridges. I see what you mean now.
> The point for me when developing th original patch

The last sentence looks incomplete; did you hit send too soon or too
late? ;)

Johan