linux-kernel - RE: [PATCH v2 2/2] phy: zynqmp: Add dt bindings for ZynqMP phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BN3PR0201MB0993F5B9CAAFB3DF83A200B6A7020@BN3PR0201MB0993.namprd02.prod.outlook.com>
Date:   Wed, 5 Sep 2018 09:32:23 +0000
From:   Anurag Kumar Vulisha <anuragku@...inx.com>
To:     Vivek Gautam <vivek.gautam@...eaurora.org>,
        "kishon@...com" <kishon@...com>, Michal Simek <michals@...inx.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>
CC:     "v.anuragkumar@...il.com" <v.anuragkumar@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: RE: [PATCH v2 2/2] phy: zynqmp: Add dt bindings for ZynqMP phy

Hi Vivek,

>> +Phy provider node
>> +=================
>> +
>> +Required properties:
>> +- compatible	: Can be "xlnx,zynqmp-psgtr-v1.1" or "xlnx,zynqmp-psgtr"
>> +		  "xlnx,zynqmp-psgtr-v1.1" has "xlnx,tx_termination_fix" removed
>This is not very clear. You can rather mention this statement for the property.
>e.g. In "xlnx,tx_termination_fix" you can write - this is not required for "xlnx,zynqmp-
>psgtr-v1.1.
>

Thanks for spending your time in reviewing this patch,  will correct this in the
next series of patch.
 
>> +
>> +- reg           : Address and length of register sets for each device in
>> +                  "reg-names"
>> +
>> +- reg-names     : The names of the register addresses corresponding to the
>> +
>> +lane1:
>> +- #phy-cells	: Should be 4
>> +
>> +lane2:
>> +- #phy-cells	: Should be 4
>> +
>> +lane3:
>> +- #phy-cells	: Should be 4
>> +
>> +Example:
>> +	serdes: zynqmp_phy@...00000 {
>
>phy is not just the serdes. Also s/zynqmp_phy/phy
>
>This could be:
>                     zynqmp_phy: phy@...00000
>
Thanks for correcting, will fix this in next series of this patch

Best Regards,
Anurag Kumar Vulisha