linux-kernel - Re: [PATCH] tpm: Make SECURITYFS a weak dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180905112847.GC9696@linux.intel.com>
Date:   Wed, 5 Sep 2018 14:28:47 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Peter Huewe <peterhuewe@....de>
Cc:     Jason Gunthorpe <jgg@...pe.ca>, linux-integrity@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-security-module@...r.kernel.org
Subject: Re: [PATCH] tpm: Make SECURITYFS a weak dependency

On Mon, Sep 03, 2018 at 09:51:51PM +0200, Peter Huewe wrote:
> While having SECURITYFS enabled for the tpm subsystem is beneficial in
> most cases, it is not strictly necessary to have it enabled at all.
> Especially on platforms without any boot firmware integration of the TPM
> (e.g. raspberry pi) it does not add any value for the tpm subsystem,
> as there is no eventlog present.
> 
> By turning it from 'select' to 'imply' it still gets selected per
> default, but enables users who want to save some kb of ram by turning
> SECURITYFS off.
> 
> Signed-off-by: Peter Huewe <peterhuewe@....de>
> ---
>  drivers/char/tpm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
> index 18c81cbe4704..536e55d3919f 100644
> --- a/drivers/char/tpm/Kconfig
> +++ b/drivers/char/tpm/Kconfig
> @@ -5,7 +5,7 @@
>  menuconfig TCG_TPM
>  	tristate "TPM Hardware Support"
>  	depends on HAS_IOMEM
> -	select SECURITYFS
> +	imply SECURITYFS
>  	select CRYPTO
>  	select CRYPTO_HASH_INFO
>  	---help---
> -- 
> 2.16.4
> 

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>

/Jarkko