linux-kernel - Re: [PATCH 1/2] staging: rtl8188eu: remove empty if statement in rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180905121005.jamftmnxr3s2qgt6@mwanda>
Date:   Wed, 5 Sep 2018 15:10:06 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Michael Straube <straube.linux@...il.com>
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] staging: rtl8188eu: remove empty if statement in
 rtw_led.c

On Wed, Sep 05, 2018 at 01:44:43PM +0200, Michael Straube wrote:
> On 9/5/18 10:13 AM, Dan Carpenter wrote:
> > On Tue, Sep 04, 2018 at 01:16:15PM +0200, Michael Straube wrote:
> > > 
> > >   	case LED_CTL_SITE_SURVEY:
> > > -		if ((pmlmepriv->LinkDetectInfo.bBusyTraffic) && (check_fwstate(pmlmepriv, _FW_LINKED))) {
> > > -			;
> > > -		} else if (!pLed->bLedScanBlinkInProgress) {
> > > +		if (!pLed->bLedScanBlinkInProgress) {
> > 
> > I think you have introduced a bug...
> 
> Ah yes I see now, thanks.
> Would it be ok to merge the conditions in a single if?
> 
> if ((!pmlmepriv->LinkDetectInfo.bBusyTraffic ||
>     !check_fwstate(pmlmepriv, _FW_LINKED)) &&
      ^
Put an extra space here because it's inside the inner parens.

>     !pLed->bLedScanBlinkInProgress) {

So it would be aligned like so:

	if ((!pmlmepriv->LinkDetectInfo.bBusyTraffic ||
	     !check_fwstate(pmlmepriv, _FW_LINKED)) &&
	    !pLed->bLedScanBlinkInProgress) {

regards,
dan capenter