linux-kernel - Re: [PATCH 07/12] Compiler Attributes: remove unneeded sparse (__CHECKER_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 5 Sep 2018 12:30:35 -0700
From:   Josh Triplett <josh@...htriplett.org>
To:     Luc Van Oostenryck <luc.vanoostenryck@...il.com>
Cc:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-kernel@...r.kernel.org,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Eli Friedman <efriedma@...eaurora.org>,
        Christopher Li <sparse@...isli.org>,
        Kees Cook <keescook@...omium.org>,
        Ingo Molnar <mingo@...nel.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Joe Perches <joe@...ches.com>,
        Dominique Martinet <asmadeus@...ewreck.org>,
        linux-sparse@...r.kernel.org
Subject: Re: [PATCH 07/12] Compiler Attributes: remove unneeded sparse
 (__CHECKER__) tests

On Wed, Sep 05, 2018 at 08:20:39PM +0200, Luc Van Oostenryck wrote:
> On Mon, Sep 03, 2018 at 10:33:11PM +0200, Miguel Ojeda wrote:
> > Sparse knows about a few more attributes now, so we can remove
> > the __CHECKER__ conditions from them (which, in turn, allow us
> > to move some of them later on to compiler_attributes.h).
> > 
> >   * assume_aligned: since sparse's commit ffc860b ("sparse:
> >     ignore __assume_aligned__ attribute"), included in 0.5.1
> > 
> >   * error: since sparse's commit 0a04210 ("sparse: Add 'error'
> >     to ignored attributes"), included in 0.5.0
> > 
> >   * hotpatch: since sparse's commit 6043210 ("sparse/parse.c:
> >     ignore hotpatch attribute"), included in 0.5.1
> > 
> >   * warning: since sparse's commit 977365d ("Avoid "attribute
> >     'warning': unknown attribute" warning"), included in 0.4.2
> 
> Hi,
> 
> I hadn't noticed in the previous version but I see now that hotpatch
> & assume_aligned is only available since sparse 0.5.1 which is only
> 13 months old. It would be great if everyone use a recent version
> but I fear that a lot of people still use something less recent.
> v0.5.0 should be OK, though, it's more than 5 years old.
> 
> Sorry for not having noticed this earlier.

Unlike GCC, I don't think it's at all unreasonable to assume a
*relatively* recent version of Sparse.

(Once we start assuming a version with __has_attribute support, this
will get even easier to handle.)