linux-kernel - Re: [PATCH] scsi: zfcp: remove redundant put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2c9a39f0-b0c3-5130-eedc-aaa33ca00d04@cmss.chinamobile.com>
Date:   Thu, 6 Sep 2018 14:43:22 +0800
From:   Ding Xiang <dingxiang@...s.chinamobile.com>
To:     Heiko Carstens <heiko.carstens@...ibm.com>
Cc:     schwidefsky@...ibm.com, linux-s390@...r.kernel.org,
        linux-kernel@...r.kernel.org, Steffen Maier <maier@...ux.ibm.com>,
        Benjamin Block <bblock@...ux.ibm.com>
Subject: Re: [PATCH] scsi: zfcp: remove redundant put_device


On 9/6/2018 2:24 PM, Heiko Carstens wrote:
> On Thu, Sep 06, 2018 at 02:16:27PM +0800, Ding Xiang wrote:
>> device_unregister will put device, do not need to do it one more time
>>
>> Signed-off-by: Ding Xiang <dingxiang@...s.chinamobile.com>
>> ---
>>   drivers/s390/scsi/zfcp_unit.c | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/s390/scsi/zfcp_unit.c b/drivers/s390/scsi/zfcp_unit.c
>> index 1bf0a09..6b50084 100644
>> --- a/drivers/s390/scsi/zfcp_unit.c
>> +++ b/drivers/s390/scsi/zfcp_unit.c
>> @@ -249,8 +249,6 @@ int zfcp_unit_remove(struct zfcp_port *port, u64 fcp_lun)
>>   		scsi_device_put(sdev);
>>   	}
>>
>> -	put_device(&unit->dev);
>> -
>>   	device_unregister(&unit->dev);
>>
>>   	return 0;
> I'm quite sure this change is wrong, since the put_device() here seems to
> pair with the get_device() in _zfcp_unit_find(). So we would end up with a
> memory leak.

Indeed，please ignore this patch.


> Adding Steffen and Benjamin.
>
>
>