linux-kernel - Re: [PATCH 05/11] UAPI: coda: Don't use internal kernel structs in UAPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9916.1536218032@warthog.procyon.org.uk>
Date:   Thu, 06 Sep 2018 08:13:52 +0100
From:   David Howells <dhowells@...hat.com>
To:     Yann Droneaud <ydroneaud@...eya.com>
Cc:     dhowells@...hat.com, linux-api@...r.kernel.org,
        linux-kbuild@...r.kernel.org, Jan Harkes <jaharkes@...cmu.edu>,
        coda@...cmu.edu, codalist@...a.cs.cmu.edu,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/11] UAPI: coda: Don't use internal kernel structs in UAPI

Yann Droneaud <ydroneaud@...eya.com> wrote:

> This structure should not have been exposed to userspace in the first
> place: it's unusable by userspace as it is. It was incorrect to have it
> outside of #ifdef __KERNEL__ before commit 607ca46e97a1b ... 
> ...
> All CODA_REQ_* defines internals to kernel side and not exchanged with
> userspace.
> 
> Please move them back to <linux/coda_psdev.h>

Is there any reason coda_psdev.h needs to be in include/linux/ rather than
fs/coda/?

David