linux-kernel - Re: [PATCH] usb: dwc2: disable power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <410670D7E743164D87FA6160E7907A56013A764835@am04wembxa.internal.synopsys.com>
Date:   Thu, 6 Sep 2018 08:36:46 +0000
From:   Minas Harutyunyan <Minas.Harutyunyan@...opsys.com>
To:     Christian Hewitt <christianshewitt@...il.com>
CC:     "hal@...emmerich.com" <hal@...emmerich.com>,
        "arthur.petrosyan@...opsys.com" <arthur.petrosyan@...opsys.com>,
        "Minas Harutyunyan" <Minas.Harutyunyan@...opsys.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: dwc2: disable power_down on Amlogic devices

On 9/5/2018 6:56 PM, Christian Hewitt wrote:
> USB devices work when connected to Amlogic GXBB hardware before power
> on, but not when connected after boot (hotplugged). With this patch
> hotplugging works again. This change was copied from the Rockchip
> patch here: (https://urldefense.proofpoint.com/v2/url?u=https-3A__marc.info_-3Fl-3Dlinux-2Dusb-26m-3D153205711616460-26w-3D2&d=DwIBAg&c=DPL6_X_6JkXFx7AXWqB0tg&r=cQBKt4q-qzNVC53rNAwuwplH23V61rHQhhULvdLA0U8&m=m5T_SsLG-_isQDyjrHuiVqJWdEqZ21Lcr70lObiPwrg&s=D26wJzWeREBz6_XcmdTqo8k69mPRqGaIbRWl_77Ns3c&e=)
> 
> Signed-off-by: Christian Hewitt <christianshewitt@...il.com>

Acked-by: Minas Harutyunyan <hminas@...opsys.com>

> ---
>   drivers/usb/dwc2/params.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
> index bf7052e..93561a2 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -110,6 +110,7 @@ static void dwc2_set_amlogic_params(struct dwc2_hsotg *hsotg)
>   	p->phy_type = DWC2_PHY_TYPE_PARAM_UTMI;
>   	p->ahbcfg = GAHBCFG_HBSTLEN_INCR8 <<
>   		GAHBCFG_HBSTLEN_SHIFT;
> +	p->power_down = false;
>   }
>   
>   static void dwc2_set_amcc_params(struct dwc2_hsotg *hsotg)
>