linux-kernel - Re: [Xen-devel] [PATCH] xen: remove redundant put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180906094712.qc2ukrtvz2jzak64@zion.uk.xensource.com>
Date:   Thu, 6 Sep 2018 10:47:12 +0100
From:   Wei Liu <wei.liu2@...rix.com>
To:     Ding Xiang <dingxiang@...s.chinamobile.com>
CC:     <boris.ostrovsky@...cle.com>, <jgross@...e.com>,
        <xen-devel@...ts.xenproject.org>, <linux-kernel@...r.kernel.org>,
        Wei Liu <wei.liu2@...rix.com>
Subject: Re: [Xen-devel] [PATCH] xen: remove redundant put_device

On Thu, Sep 06, 2018 at 02:33:10PM +0800, Ding Xiang wrote:
> device_unregister will put device, do not need to do it one more time
> 
> Signed-off-by: Ding Xiang <dingxiang@...s.chinamobile.com>
> ---
>  drivers/xen/xenbus/xenbus_probe.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c
> index 5b47188..cfaa878 100644
> --- a/drivers/xen/xenbus/xenbus_probe.c
> +++ b/drivers/xen/xenbus/xenbus_probe.c
> @@ -369,7 +369,6 @@ static void xenbus_cleanup_devices(const char *path, struct bus_type *bus)
>  		bus_for_each_dev(bus, NULL, &info, cleanup_dev);
>  		if (info.dev) {
>  			device_unregister(&info.dev->dev);
> -			put_device(&info.dev->dev);

This is to match the get_device call in cleanup_dev. It is not redundant
IMHO.

Wei.