linux-kernel - Re: [PATCH v7 1/2]: perf util: map data buffer for preserving collected data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <668c4974-27be-2546-0284-5b72c2a9a0e1@linux.intel.com>
Date:   Thu, 6 Sep 2018 14:54:45 +0300
From:   Alexey Budankov <alexey.budankov@...ux.intel.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Andi Kleen <ak@...ux.intel.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 1/2]: perf util: map data buffer for preserving
 collected data



On 06.09.2018 14:04, Jiri Olsa wrote:
> On Wed, Sep 05, 2018 at 10:19:56AM +0300, Alexey Budankov wrote:
> 
> SNIP
> 
>> @@ -166,6 +174,7 @@ void perf_mmap__munmap(struct perf_mmap *map)
>>  
>>  int perf_mmap__mmap(struct perf_mmap *map, struct mmap_params *mp, int fd)
>>  {
>> +	int i;
>>  	/*
>>  	 * The last one will be done at perf_mmap__consume(), so that we
>>  	 * make sure we don't prevent tools from consuming every last event in
>> @@ -190,6 +199,50 @@ int perf_mmap__mmap(struct perf_mmap *map, struct mmap_params *mp, int fd)
>>  		map->base = NULL;
>>  		return -1;
>>  	}
>> +	map->nr_cblocks = mp->nr_cblocks;
>> +	map->cblocks = calloc(map->nr_cblocks, sizeof(struct aiocb*));
>> +	if (!map->cblocks) {
>> +		pr_debug2("failed to allocate perf event data buffers, error %d\n",
>> +				errno);
>> +		return -1;
>> +	}
>> +	map->data = calloc(map->nr_cblocks, sizeof(void*));
>> +	if (map->data) {
>> +		int delta_max = sysconf(_SC_AIO_PRIO_DELTA_MAX);
>> +		for (i = 0; i < map->nr_cblocks; ++i) {
>> +			map->data[i] = malloc(perf_mmap__mmap_len(map));
>> +			if (map->data[i]) {
>> +				int prio;
>> +				unsigned char *data = map->data[i];
>> +				map->cblocks[i] = (struct aiocb *)&data[map->mask + 1];
> 
> the 'struct aiocb' is allocated at the last page of the buffer?
> is that enough space? could we please make this more transparent
> and allocate that space separately?

Would the array of pointers followed by the array of referenced objects fit?

> 
> thanks,
> jirka
>